Allow click 8.3.x series, excluding 8.3.0#297
Merged
stefanv merged 2 commits intoscientific-python:mainfrom Jan 6, 2026
Merged
Allow click 8.3.x series, excluding 8.3.0#297stefanv merged 2 commits intoscientific-python:mainfrom
stefanv merged 2 commits intoscientific-python:mainfrom
Conversation
Click 8.3.0 broke spin because Sentinel objects are now passed instead of defaults in some instances: pallets/click#3065 8.3.1 will include two workarounds: pallets/click#3065 (comment) I suspect pallets/click#3068 will address our problem.
Member
Author
|
Leave this PR open until 8.3.1 is released, then re-run CI (tests pass right now because 8.3.0 is excluded, but we need to see what happens once 8.3.1 is used). |
Closed
Member
Author
|
Tests passed here and on main, but failing over at #304 with the sentinel error I expected to see here. Will revert for now. |
stefanv
added a commit
that referenced
this pull request
Jan 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Click 8.3.0 broke spin because Sentinel objects are now passed instead of defaults in some instances:
pallets/click#3065
8.3.1 will include two workarounds:
pallets/click#3065 (comment)
I suspect
pallets/click#3068
will address our problem.